Re: [libvirt] PATCH: 4/4: Test the event loop impl
On Mon, May 11, 2009 at 12:25:08PM +0100, Daniel P. Berrange wrote:
This patch adds a new test case to validate the various wierd
scenarios that
can occur when adding/removing/updating watches & timers in the event loop.
In particular it checks
- Handling of watches marked as deleted before virEventRunOnce
- Handling of watches marked as deleted during dispatch of poll() results
- Correct interrupt of main thread if watches change during poll() sleep
These are the 3 problems we've been hitting with all these issues. I've
tested they all fail prior to this patch
http://www.redhat.com/archives/libvir-list/2009-March/msg00246.html
and now all 3 pass
Okay, it would be great to have a slightly more generic framework
for event tesing using for example scenarios files, but that's a good
first step,
ACK !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/