On 12/03/2012 03:14 PM, Eric Blake wrote:
Commit 71d1256 tried to fix a problem where rebasing an old branch on top of newer libvirt.git resulted in automake failing because of a missing AUTHORS file. However, while the fix worked for an incremental 'make', it did not work for someone that directly reran './autogen.sh'. Reported by Laine Stump.
* autogen.sh (autoreconf): Check for same conditions as cfg.mk. * cfg.mk (_update_required): Add comments. --- autogen.sh | 3 ++- cfg.mk | 2 ++ 2 files changed, 4 insertions(+), 1 deletions(-)
I'm not sure how if it impacts this particular change, but why don't we switch to AM_INIT_AUTOMAKE([foreign]) ? Since AUTHORS or ChangeLog are no longer static, it seems we are just causing ourselves pain by trying to work around auto* insisting those files exist. Then again I don't know what benefits non-foreign gives us... - Cole