Re: [libvirt] [PATCH] hash: fix memory leak and regression

On 04/29/2011 03:53 PM, Eric Blake wrote: > Commit 1671d1d introduced a memory leak in virHashFree, and > wholesale table corruption in virHashRemoveSet (elements not > requested to be freed are lost). > > * src/util/hash.c (virHashFree): Free bucket array. > (virHashRemoveSet): Don't lose elements. > * tests/hashtest.c (testHashCheckForEachCount): New method. > (testHashCheckCount): Expose the bug. > --- > src/util/hash.c | 6 +++--- > tests/hashtest.c | 15 +++++++++++++++ > 2 files changed, 18 insertions(+), 3 deletions(-)

ACK.