On Sat, Nov 07, 2009 at 03:26:15AM +0100, Maximilian Wilhelm wrote:
Anno domini 2009 Daniel Veillard scripsit:
[persistent migration for Xen]
> Yes adding a different error with a clear semantic so that the
> management code can understand the current situation and not assume the
> domain in still running on the source node sounds the right approach to
> me. We can't make this a completely atomic operation, so we need to deal
> with this !
> Patch welcome :-) Thanks !
So, after a bit of delay due to some private things, here we are.
> Any chance you could provide an updated patch for the Xen side
> independantly, or did I missed it ?
I wanted to do it "right" on the first shot, therefore I didn't post
an updated patch with my last mail. :)
* src/xen/xen_driver.c: Add support for VIR_MIGRATE_PERSIST_DEST flag
* src/xen/xend_internal.c: Add support for VIR_MIGRATE_UNDEFINE_SOURCE flag
* include/libvirt/virterror.h, src/util/virterror.c: Add new errorcode
VIR_ERR_MIGRATE_PERSIST_FAILED
Oops I newarly forgot that patch !
Looks fine, ACK, I just shortened the error message for the new error
code a bit to fit on one line.
Applied,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine
http://rpmfind.net/
http://veillard.com/ | virtualization library
http://libvirt.org/