Re: [libvirt] [PATCH] libxl: Set path to console on domain startup

On 12/05/2014 05:30 PM, Anthony PERARD wrote: > Hi, > > I'm trying to fix an issue when using OpenStack with libvirt+xen (libxenlight). > OpenStack cannot access the console output of a Xen PV guest, because the XML > generated by libvirt for a domain is missing the path to the pty. The path > actually appear in the XML once one call virDomainOpenConsole(). > > The patch intend to get the path to the pty without having to call > virDomainOpenConsole, so I've done the work in libxlDomainStart(). So I have a > few question: > Is libxlDomainStart will be called on restore/migrate/reboot? > I guest the function libxlDomainOpenConsole() would not need to do the same > work if the console path is settup properly. > > There is a bug report about this: > https://bugzilla.redhat.com/show_bug.cgi?id=1170743 > Hi, you can leave the bugzilla link in the commit message, if somebody ever needs more context.

(And the patch looks good to me, but I'm no libxl expert)