Re: [Libvir] [PATCH] Fix string handling in virDomain{Get, Set}SchedulerParameters

"Richard W.M. Jones" <rjones@redhat.com> wrote:

This small patch fixes some bugs in the handling of the field string in virDomainGetSchedulerParameters and makes a similar pre-emptive fix to virDomainSetSchedulerParameters.

Also, please don't use !strcmp(a,b), because it confuses me. Better is to write strcmp(a,b) == 0 to mean "strings match" and strcmp(a,b) != 0 to mean "strings don't match".

Hi Rich, I agree, but prefer to avoid direct use of strcmp altogether. I use this definition: #define STREQ(a, b) (strcmp (a, b) == 0) Then all uses are either STREQ(a, b) or ! STREQ(a, b)