Re: [libvirt] [PATCHv2 01/10] Replace sscanf in legacy device address parsing

Parsing is stricter now and doesn't accept trailing characters after the actual <domain>:<bus>:<slot> sequence anymore. +static int +virDomainParseLegacyDeviceAddress(char *devaddr, + virDomainDevicePCIAddressPtr pci) +{ + char *tmp; + + /* expected format: <domain>:<bus>:<slot> */ + if (/* domain */ + virStrToLong_ui(devaddr, &tmp, 16, &pci->domain) < 0 || *tmp != ':' || + /* bus */ + virStrToLong_ui(tmp + 1, &tmp, 16, &pci->bus) < 0 || *tmp != ':' || + /* slot */ + virStrToLong_ui(tmp + 1, NULL, 16, &pci->slot) < 0) + return -1; + + return 0; +}