Re: [libvirt] [PATCH 3/8] Add APIs to allow management of callbacks purely with virDomainEventState

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; While virDomainEventState has APIs for managing removal of callbacks, while locked, adding callbacks in the first place requires direct access to the virDomainEventCallbackList structure. This is not threadsafe since it is bypassing the virDomainEventState locks * src/conf/domain_event.c, src/conf/domain_event.h, src/libvirt_private.syms: Add APIs for managing callbacks via virDomainEventState. --- src/conf/domain_event.c | 99 ++++++++++++++++++++++++++++++++++++++++++++++ src/conf/domain_event.h | 24 +++++++++++ src/libvirt_private.syms | 4 ++ 3 files changed, 127 insertions(+), 0 deletions(-)

/** + * virDomainEventStateRegister: + * @state: domain event state + * @conn: connection to associate with callback

+ * @callback: function to remove from event + * @opaque: data blob to pass to callback + * @freecb: callback to free @opaque + * + * Register the function @callback with connection @conn, + * from @state, for lifecycle events. + * + * Returns: the number of lifecycle callbacks now registered, or -1 on error + */ +int virDomainEventStateRegister(virConnectPtr conn, + virDomainEventStatePtr state,

+/** + * virDomainEventStateRegisterID: + * @state: domain event state + * @conn: connection to associate with callback

+/** + * virDomainEventStateDeregisterConn: + * @state: domain event state + * @conn: connection to associate with callbacks

+ + +int +virDomainEventStateEventID(virConnectPtr conn, + virDomainEventStatePtr state, + int callbackID)

+++ b/src/libvirt_private.syms @@ -511,6 +511,10 @@ virDomainEventRebootNewFromDom; virDomainEventRebootNewFromObj; virDomainEventStateDeregister; virDomainEventStateDeregisterID; +virDomainEventStateDeregisterConn;