Re: [libvirt] [PATCH 08/12] tests: Add test cases for external swtpm TPM emulator

On Tue, May 22, 2018 at 04:44:49PM -0400, Stefan Berger wrote: > This patch adds extensions to existing test cases and specific test > cases > for the tpm-emulator. > > Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; > Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > .../tpm-emulator.x86_64-latest.args                | 33 > ++++++++++++++++++++++ > tests/qemuxml2argvtest.c                           | 15 +++++++++- > 2 files changed, 47 insertions(+), 1 deletion(-) > create mode 100644 > tests/qemuxml2argvdata/tpm-emulator.x86_64-latest.args > > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 78454acb1a..587f15242e 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -532,6 +532,19 @@ testCompareXMLToArgv(const void *data) >         } >     } > > +    if (vm->def->tpm) { > +       switch (vm->def->tpm->type) { > +       case VIR_DOMAIN_TPM_TYPE_EMULATOR: > +           if > (VIR_STRDUP(vm->def->tpm->data.emulator.source.data.file.path, > +                          "/dev/test") < 0) > +               goto cleanup; > +           break; > +       case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH: > +       case VIR_DOMAIN_TPM_TYPE_LAST: > +           break; > +       } This is indented by three spaces instead of four.

Jano