Re: [libvirt] [PATCH 3/3] storage: Resolve issues with disk partition build/start checks

On Fri, Apr 07, 2017 at 07:49:59 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1439132 > > Fix some issues discovered when building between multiple different > supported disk partition types. > > 1. The "dvh" and "pc98" were specifically checked during the blkid > partition processing in commit id 'a48c674fb', but commit id 'a4cb4a74f' > really messed things up by missing an else condition causing PARTEDFindLabel > to always return DIFFERENT. > > 2. Add the "bsd" to the list of format types to not checked during > blkid processing even though it supposedly knows the format - for some > (now unknown) reason it's returning partiion not found. So let's just > let PARTED handle that too. > > 3. During 'matrix' testing of all possible combinations I found that if > device is formated with "gpt" first, then an attempt is made to format > using "mac", a startup will fail. By adding a clearing of the first > 2048 bytes of the device (similar to the logical pool code), the issue > is resolved. Looks like 3 separate bugs to me. Why are all the fixes in a single commit?