Re: [libvirt] [PATCHv5 08/19] util: Add interface for creating monitor group

[...] > 402 virResctrlMonitorDispose(void *obj) > 403 { > 404 virResctrlMonitorPtr monitor = obj; > 405 > 406 virObjectUnref(monitor->alloc); > 407 VIR_FREE(monitor->id); > 408 VIR_FREE(monitor->path); > 409 } >> The one "thing" about the order of patches here is that it forces me to >> look forward to ensure decisions made in previous patches will be >> handled in the future. > Maybe combine virResctrlMonitorDispose and virResctrlMonitorCreate in one > patch? Will that make you look better for understanding how @monitor->alloc > is used. That usually is best. I think the order has me off a bit too, but there is no perfect solution for order. I find myself looking forward a lot and trying to keep track.

John