Re: [Libvir] [PATCH] Add virDomainGetConnect and virNetworkGetConnect
On Mon, Jun 25, 2007 at 02:58:48PM +0100, Richard W.M. Jones wrote:
As described in this thread:
https://www.redhat.com/archives/libvir-list/2007-June/thread.html#00352
* These functions don't change the reference count for virConnectPtr.
It's be a pain in the neck for callers otherwise.
* I haven't changed the Python bindings, because I'm not confident
enough that I can do that correctly and keep it backwards compatible for
all callers (and anyway what would happen if newer Python bindings were
used together with an older libvirt?). However I did add a comment to
the generator noting that this could be changed in future.
* I tested this with the OCaml bindings with no apparent ill-effects.
Looks fine, but change virNetworkGetConnect comment to use "network"
and not "connection" ;-)
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/