On Tue, May 15, 2018 at 07:23:28PM +0200, Andrea Bolognani wrote:
On Tue, 2018-05-15 at 16:32 +0100, Daniel P. Berrangé wrote:
The Module::Build system is nicer than ExtUtils::MakeMaker as it allows for better cross-platform portability by only relying on Perl, rather than both Perl and system 'make' binary.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- .gitignore | 17 +++---- Build.PL | 102 +++++++++++++++++++++++++++++++++++++ MANIFEST | 73 ++++++++++++++++++++++++++ MANIFEST.SKIP | 20 -------- META.yml.PL | 55 -------------------- Makefile.PL | 85 ------------------------------- autobuild.sh | 55 +++----------------- Virt.xs => lib/Sys/Virt.xs | 0 perl-Sys-Virt.spec.PL | 45 ++++++++-------- t/030-api-coverage.t | 2 +- 10 files changed, 210 insertions(+), 244 deletions(-) create mode 100755 Build.PL create mode 100644 MANIFEST delete mode 100644 MANIFEST.SKIP delete mode 100644 META.yml.PL delete mode 100644 Makefile.PL rename Virt.xs => lib/Sys/Virt.xs (100%)
Disclaimer: I know nothing about Perl.
[...]
diff --git a/MANIFEST b/MANIFEST new file mode 100644 index 0000000..d425ef1 --- /dev/null +++ b/MANIFEST @@ -0,0 +1,73 @@ +.gitignore +.gitpublish +AUTHORS +Build.PL +Changes +HACKING +INSTALL +LICENSE +README +autobuild.sh
We renamed this script a week or so ago. Please make sure you pull before hacking next time ;)
Heh, yeah, i sent a v2 that is rebased to master.
[...]
diff --git a/autobuild.sh b/autobuild.sh index 9a6d102..597b9bf 100755 --- a/autobuild.sh +++ b/autobuild.sh
This hunk doesn't apply at all now, of course...
Lastly, the RPM build fails with
RPM build errors: Empty %files file /home/test/libvirt-perl/rpmbuild/BUILD/Sys-Virt-v4.4.0/debugsourcefiles.list
on Fedora. It passes on CentOS 7, though.
Rather strange - i have no trouble with that on Fedora 28 at least. How were you triggering the RPM build ? I wonder if perhaps there was any stale files from MakeMaker causing it ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|