Re: [libvirt] [PATCHv2] qemu: don't leak vm on failure

On 09/06/2013 11:55 AM, Eric Blake wrote:

Failure to attach to a domain during 'virsh qemu-attach' left the list of domains in an odd state:

$ virsh qemu-attach 4176 error: An error occurred, but the cause is unknown

-endjob: if (qemuDomainObjEndJob(driver, vm) == 0) { vm = NULL; - goto cleanup; - }

Hmm, I see that I tested something slightly different than what I posted (the '{' needs to be deleted to match the '}' cleanup). Consider that squashed in. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org