Re: [libvirt] [PATCH] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

>> - if (list) >> - fclose(list); >> - else >> - VIR_FORCE_CLOSE(fd); >> + VIR_FORCE_FCLOSE(list); >> + VIR_FORCE_CLOSE(fd); > You just introduced a double close. list was created via fdopen(fd), :-( In that case, what about wrapping fdopen with FDOPEN and set fd to -1 if the function succeeds, i.e., returns != NULL? > which effectively consumes fd. Maybe we need to add VIR_FDOPEN which > auto-sets an fdopen'd fd to -1 on success? Maybe not, but then you need > to adjust the fdopen() call site to invalidate fd so we don't re-close > it.