On 01/16/2014 06:14 AM, Peter Krempa wrote:
Add support for gluster backed images as sources for snapshots in the qemu driver. This will also simplify adding further network backed volumes as sources for snapshot in case qemu will support them. --- docs/formatsnapshot.html.in | 4 +- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 9 ++++ src/qemu/qemu_driver.c | 113 +++++++++++++++++++++++++++++++++++++++++--- 4 files changed, 118 insertions(+), 10 deletions(-)
Libvirt currently supports the <code>type</code> element in the qemu - driver and supported values are <code>file</code> and - <code>block</code> <span class="since">(since 1.2.2)</span>. + driver and supported values are <code>file</code>, <code>block</code> + and <code>gluster</code> <span class="since">(since 1.2.2)</span>.
Rather, type <code>network</code> with a protocol of gluster.
+ + return qemuGetDriveSourceString(qemuSnapshotDiskGetActualType(disk),
qemuSnapshotDiskGetActualType(disk) is now just a fancy wrapper around disk->type, since 4/9. Do we even need that function, or can we just delete it and simplify all callers? ACK with those fixes. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org