On 07/23/2012 09:08 PM, Guannan Ren wrote:
On 07/23/2012 11:10 PM, Eric Blake wrote:
On 07/20/2012 07:47 AM, Guannan Ren wrote:
libvirt asks the duration time is above 60 seconds in code
-specified by the 'duration' parameter. +specified by the 'duration' parameter. The duration time should be above +60 seconds. and again.
ACK with that wording change.
'at least 61' sounds better than 'above 60', if we don't change the code.
Sorry, "at least 60 seconds" means the 60 is permissible minimun value. but actually according to the code, the 61 seconds is the minimun value. Or we change the code from "<=" to "<"?
if (alarmTime <= MIN_TIME_REQ_FOR_SUSPEND) {
Indeed, this seems like an off-by-one, changing it to '<' makes sense. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org