Re: [libvirt] [PATCH v2 1/5] qemu_command: Move SDL command line building into helper

On 05/10/2018 06:53 AM, Maciej Wolny wrote:

Create a function called `qemuBuildGraphicsSDLCommandLine` which is called from qemuBuildGraphicsCommandLine.

Signed-off-by: Maciej Wolny <maciej.wolny@codethink.co.uk> --- src/qemu/qemu_command.c | 49 +++++++++++++++++++++++++++++-------------------- 1 file changed, 29 insertions(+), 20 deletions(-)

Reviewed-by: John Ferlan <jferlan@redhat.com> John [yes, the new function could be a void now, but it's changing in a couple patches so leave things as is]