Re: [libvirt] [PATCH v2 0/3] Better syntax-check on BSD

On Thu, Jan 03, 2019 at 01:41:56PM -0600, Eric Blake wrote:

Since v1: fix the gnulib bug I accidentally introduced, then copy the gist of Roman's gnulib changes to also apply to our cfg.mk syntax checks.

Eric Blake (3): maint: update gnulib for syntax-check on BSD maint: prefer $(GREP) in cfg.mk maint: split long lines for BSD syntax-check

.gnulib | 2 +- cfg.mk | 95 +++++++++++++++++++++++++++++---------------------------- 2 files changed, 49 insertions(+), 48 deletions(-)

-- 2.20.1

Hi Eric, Thank you for making the changes. I'm sorry I was on vacation and wasn't able to reply earlier. I've run 'make syntax-check' on libvirt's HEAD. It succeeds on macOS. Perhaps we can add syntax-check to .travis.yml? Best regards, Roman