Re: [libvirt] [PATCH] Fix up "make check"
On Wed, Sep 23, 2009 at 09:33:58AM +0200, Chris Lalancette wrote:
While running make check, I noticed that it was actually using
the virsh binary from my system, in /usr/bin/virsh, and not the
one that was just compiled. This doesn't seem to be the intent,
so I changed all of the test scripts to point to the one built
in-tree, not the system one.
Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
Oh that's because the 'path_add' variable in tests/Makefile.am
needs updating, though its not a bad idea ot make it explicit
in each test like you've done too. Can you use the relative
paths like $srcdir/../tools/ instead though, because
abs_* do not exist on RHEL-5 vintage automake - also each
of these shell scripts should be setting
test -z "$srcdir" && srcdir="."
as the first thing it does, so that you can run each test
directory, instead of via make.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|