Re: [Libvir] CPU pinning of domains at creation time

On Wed, Oct 17, 2007 at 10:14:56PM -0400, beth kon wrote: > This is certainly a nit, but I might change parseCpuNumber to > parseNumber, since it looks a little odd that you are getting the cell > id from the cpu number. A nit to be sure! well, the only problem is if you have more cells than maxcpu, which doesn't make that much sense. Since we are testing against maxcpu I really think we should keep the function name, I can duplicate code and make a simpler function just for parsing the cell no. > Other than our discussion on #virt about handling of ^N specifications > in parseCpuSet, looks good! Which is done in my version, will propagate.