Re: [libvirt] [PATCH 5/9] conf: snapshot: dump/parse persistent domain config
On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
Persistent in this case is a persistent config of active
of the active
persistent domain. We need it for metadata to be complete
as explained in previous patch.
Hence why I think the two should be combined.
Config is saved like this:
<domainsnapshot>
<persistent>
<domain>
...
</domain>
</persistent>
</domainsnapshot>
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com>
---
src/conf/snapshot_conf.c | 26 +++++++
.../active_inactive_domain.xml | 85 ++++++++++++++++++++++
tests/domainsnapshotxml2xmltest.c | 1 +
3 files changed, 112 insertions(+)
create mode 100644 tests/domainsnapshotxml2xmlout/active_inactive_domain.xml
Seems reasonable to me...
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John