On 05/18/2016 02:36 AM, Nishith Shah wrote:
According to QEMU docs, the '-m' option for specifying RAM is
by default
in MiB, and a suffix of "M" or "G" may be passed for values in MiB
and
GiB respectively. This commit adds support and a test for the same.
Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=812295
Signed-off-by: Nishith Shah <nishithshah.2211(a)gmail.com>
---
src/qemu/qemu_parse_command.c | 12 ++++++--
tests/qemuargv2xmldata/qemuargv2xml-mem-scale.args | 22 +++++++++++++++
tests/qemuargv2xmldata/qemuargv2xml-mem-scale.xml | 33 ++++++++++++++++++++++
tests/qemuargv2xmltest.c | 1 +
4 files changed, 66 insertions(+), 2 deletions(-)
create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-mem-scale.args
create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-mem-scale.xml
diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
index 334dcf8..f027d51 100644
--- a/src/qemu/qemu_parse_command.c
+++ b/src/qemu/qemu_parse_command.c
@@ -1638,14 +1638,22 @@ qemuParseCommandLineMem(virDomainDefPtr dom,
{
unsigned long long mem;
char *end;
+
This whitespace change should be part of patch #1
Otherwise the patches look good to me, bring on v3 :)
Thanks,
Cole