Re: [libvirt] [PATCH 1/4] qemu: get arch name from <cpu> element
On 01/24/2012 02:28 PM, Jiri Denemark wrote:
> > The idea is that, if you were using -cpu just to set
"-cpu
> > {qemu,kvm}{32,64},-kvmclock", you will not get an irrelevant
> > <cpu><model>qemu32</model></cpu> in domxml-from-native
output.
Yeah, I understand why you did so, however, you just discard {qemu,kvm}{32,64}
models even if there were more flags than just +-kvmclock specified, don't
you?
Right, that gives "Non-empty feature list specified without CPU model"
when you later start the domain. I'll fix this.
Anyway,<cpu><model>qemu32</model></cpu>
doesn't seem irrelevant to me,
it just describes the guest visible hardware.
Yeah, but arch="i686" says the same (kvm32/kvm64 shouldn't be considered
by this code, only qemu32/qemu64).
Paolo