On Nov 4, 2020, at 12:05 PM, Peter Krempa <pkrempa@redhat.com> wrote:
Our hash table API was surprisingly close to glibs.
v2: - pushed ACK'd patch - typo fix - rebased on current master - hashing function not replaced as our has random initialization
Peter Krempa (12): virhashtest: testHashGetItems: Remove test case for sorting by value util: hash: Rewrite sorting of elements in virHashGetItems util: hash: Introduce virHashForEachSorted Use virHashForEachSorted in tested code tests: remove virdeterministichashmock.so util: hash: Add delete-safe hash iterator util: hash: Use virHashForEachSafe in places which might delete the element util: hash: Don't use 'const' with virHashTablePtr util: hash: Reimplement virHashTable using GHashTable util: hash: Retire 'virHashTable' in favor of 'GHashTable' util: hash: Add deprecation notices for functions which have g_hash_table replacements tests: Remove 'virhashtest'
I built it locally and tested against a Hyper-V server. Looks good to me. Reviewed-by: Matt Coleman <matt@datto.com> -- Matt