Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in

On 11/11/2010 01:39 PM, Matthias Bolte wrote: > Tweak pre tags in docs/hacking.html.in to achieve proper > indentation of their plaintext representation. > > Also use more b/i/code tags in docs/hacking.html.in. > --- >  HACKING              |  602 +++++++++++++++++++++++++++++--------------------- A lot of this diff is whitespace; the rest looks like it is pulling in missed bits.  Overall, it looks pretty decent; and it's certainly more maintainable! >  Makefile.am          |    8 + >  docs/hacking.html.in |  351 ++++++++++++++++-------------- Would you mind splitting this into two patches?  One that cleans up just hacking.html.in, and the rest that covers going from a clean source file into the new generated HACKING file.

> +++ b/Makefile.am > @@ -48,6 +48,8 @@ EXTRA_DIST = \ >  pkgconfigdir = $(libdir)/pkgconfig >  pkgconfig_DATA = libvirt.pc > > +all: NEWS HACKING Hmm.  This means that everyone will attempt to build NEWS and HACKING, even if they don't have the prerequisite tools.

>         $(XSLTPROC) --nonet $(top_srcdir)/docs/news.xsl       \ > @@ -56,6 +58,12 @@ NEWS: $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.in >          | perl -pe 's/[ \t]+$$//'                            \ >          > $@-t && mv $@-t $@ ; fi ); > > +HACKING: $(top_srcdir)/docs/hacking1.xsl $(top_srcdir)/docs/hacking2.xsl \

If HACKING stays in git, then it must also reside in $(srcdir) rather than $(builddir), which means this rule needs a bit of tweaking to be VPATH-friendly.