On 04/16/2016 10:17 AM, John Ferlan wrote:
Similar to the qemuDomainSecretDiskPrepare, generate the secret
for the Hostdev's prior to call qemuProcessLaunch which calls
qemuBuildCommandLine. Additionally, since the secret is not longer
added as part of building the command, the hotplug code will need
to make the call to add the secret in the hostdevPriv.
Since this then is the last requirement to pass a virConnectPtr
to qemuBuildCommandLine, we now can remove that as part of these
changes. That removal has cascading effects through various callers.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
ACK
The mixed in virConnectPtr droppage is a pain :) In the future I'd suggest
annotating it with ATTRIBUTE_UNUSED in the functional patches, then dropping
it entirely in a separate patch. If this series goes v3 please don't worry
about it though
- Cole