Re: [libvirt] [PATCH] qemudDomainCreate: also check uuid
On Wed, Jul 30, 2008 at 12:05:56AM -0500, Charles Duffy wrote:
It appears that this patch was applied (in commit
45616162db2d1e807dbe70e60c67cb701cbd06d8) with the virDomainIsActive(vm)
checks removed from qemudDomainCreate, such that we fail out with
"domain [...] is already defined and running" even if the domain is only
defined but not running.
The attached (completely trivial) patch (created against
301cbb70aa52db2d8c42bc9f9441366385f0a9c4) resolves this.
I agree that the message is wrong. But the idea that you can't create a
temporary domain if there is one already defined with the same name or
UUID seems sound to me.
Are you disagreeing with the message (which your patch doesn't fix)
or with the semantic of the check (and then why allow to create a domain
reusing the UUID of another defined but not running domain, I can only
see confusion or security problems in doing so)
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/