On 01/22/2013 01:29 PM, Daniel P. Berrange wrote:
On Tue, Jan 22, 2013 at 01:09:50PM -0500, Stefan Berger wrote:
> Add two API calls to virCommand for generating the parameters necessary
> for passing to the QEMU -add-fd option, for example "set=10,fd=20",
> and the file descriptor set for the path= option, such as for example
> "/dev/fdset/10"
>
> Regards,
> Stefan
>
> ---
> src/libvirt_private.syms | 2 +
> src/util/vircommand.c | 65 +++++++++++++++++++++++++++++++++++++++++++----
> src/util/vircommand.h | 6 ++++
> 3 files changed, 68 insertions(+), 5 deletions(-)
This is the wrong place to be adding QEMU specific APIs - it should
be in qemu_command.{c,h}
Assuming I move the code into qemu_command.c, are the function calls ok?
Stefan