Re: [libvirt] [PATCH v2] phyp: Fix NULL dereference in phypConnectOpen

On 11/10/2014 01:41 AM, Martin Kletzander wrote:

Coverity found out that commit cd490086 caused a possible NULL pointer dereference. This is due to the fact, that phyp_driver is NULL at the time of closing the socket, instead of connection_data, which kept the socket before the mentioned commit, could not be NULL.

However, internal_socket is still the local socket that can be closed, even unconditionally, if we initialize it to -1.

This works too... ACK, John