Re: [libvirt] [PATCH 1/5] phyp: Remove stack allocating a 4kb volume key and fix related memory leaks

2011/4/11 Daniel Veillard <veillard@redhat.com>:

On Sat, Apr 09, 2011 at 11:59:07AM +0200, Matthias Bolte wrote:

...

Don't pre-allocate 4kb per key, make phypVolumeGetKey allocate the memory.

Make phypBuildVolume return the volume key instead of using pre-allocated memory to store it.

Also fix a memory leak in phypVolumeLookupByName when phypVolumeGetKey fails. Fix another memory leak in phypVolumeLookupByPath in the success path. Fix phypVolumeGetXMLDesc leaking voldef.key. ---  src/phyp/phyp_driver.c |   98 ++++++++++++++++++++++++++---------------------  src/phyp/phyp_driver.h |    1 -  2 files changed, 54 insertions(+), 45 deletions(-)

 ACK, way nicer !

Daniel

Thanks, pushed. Matthias