Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt
On Thu, Mar 19, 2009 at 02:12:21PM +0100, Pritesh Kothari wrote:
Hi Daniel,
>
> > +VBOX_DRIVER_SOURCES = \
> > + vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \
> > + vbox/vbox_driver.c vbox/vbox_driver.h \
> > + vbox/vbox_V2_2.c
>
> Hum, I wonder about the need of a subdirectory here, others
> drivers are directly in src/ ... maybe it's a good idea, but
> that's different from current practice.
Actually src/ now has 140+ files and I thought it would be better if every
driver got his own place ;)
> affect this too
>
> > +#ifdef WITH_VBOX
> > +#include "vbox/vbox_driver.h"
> > +#endif
> > #endif
that was related to the vbox subdir comment was above
> Otherwise that part of the patch looks good.
> Is there really no need for checkings at configure time ?
I didn't understand this, do you mean the #ifdef is not necessary?
i will remove it then.
nahh, I was wondering if vbox support locally should be done in
configure.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/