Re: [libvirt PATCH 2/8] bridge: include netdev_bandwidth_conf.h
On Tue, Feb 25, 2020 at 04:37:28PM +0100, Michal Privoznik wrote:
On 2/22/20 5:31 PM, Ján Tomko wrote:
>This file uses the virNetDevBandwidth*Floor helpers
>without including the correct include,
>relying on virnetworkportdef.h to include it.
>
>Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
>Fixes: 17f430eb5cfaaa3388077f2b0856f011f0b2a4c3
I have a question about this "Fixes" field.
Feel free to ask it ;)
I've noticed you put it
into some commit messages, but I can't figure out the pattern. I
thought that you are blaming commits from previous releases (to help
distro maintainers), but the commit you are referencing here is in the
same release as this one. And some commits in this series don't have
the field at all.
It is to leave a trace for future readers.
The pattern is - I put it in in cases where I was bothered to look for
it - here it was because rebasing on master actually broke the build
for me. For other bugs, I'm usually curious how long that has been
broken or in which releases we need to fix this.
Of course,
a) the wording "Fixes" in this case is similar to using "Resolves"
for a related bugzilla link - Fixes somehow implies it was "broken".
We cannot really consider a patch that complies correctly broken.
The more accurate wording would be 'I-would-have-squashed-this-into:'
b) I assume nobody is going to backport an include cleanup, so it is
not useful in that regard either.
Hope this answers your untold question.
Jano
Michal
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)