On Thu, May 02, 2013 at 12:53:33AM +0200, Andreas Färber wrote:
> Eduardo Habkost (9):
> target-i386: cleanup: Group together level, xlevel, xlevel2 fields
> target-i386/kvm.c: Code formatting changes
> target-i386/cpu.c: Break lines so they don't get too long
> target-i386: Replace cpuid_*features fields with a feature word array
Thanks, applied these to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
These had been around for quite some time and I have reviewed the first
three line by line; for the fourth I have looked at the script sources
and trust Igor's review. Thanks for repeatedly rebasing this, Eduardo!
Thanks!
> target-i386: Add ECX information to FeatureWordInfo
This one is lacking Reviewed-by / Acked-by ...
> target-i386: Add "feature-words" property
> target-i386: Use FeatureWord loop on filter_features_for_kvm()
... and this one seems to depend on it.
> target-i386: Introduce X86CPU.filtered_features field
> target-i386: Add "filtered-features" property to X86CPU
As mentioned earlier I'd prefer to defer the property design rather than
putting it lightly reviewed into 1.5 and living with some ABI.
If libvirt urgently needs this info, this series needs to be reviewed
and sorted out until the weekend (Hard Freeze on Monday).
I consider it an important bugfix for the QEMU+libvirt stack. The
current libvirt behavior (checking CPUID directly; not using the
"enforce" flag; and having its own copy of each CPU model definition) is
unsafe and may break live-migration silently under many circumstances.
--
Eduardo