Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 02:14:34PM +0100, Richard W.M. Jones wrote:
On Tue, Jun 10, 2008 at 09:36:50PM +0900, Atsushi SAKAI wrote:
> When the user forget to add "phy" or "file" in VM image path,
> The error handled on libvirt previously without error message now.
>
> This patch change the VM image path error handling from libvirt to Xend.
> For this purpose, libvirt just pass VM image path without check.
> Xend reports error with following Xen patch.
Yes, I think it looks fine. Any comments Dan?
If it doesn't break the XM test suite then its probably ok to commit - if
someone can add an extra test case datafile for it, even better. Though
I'm still not entirely clear on why its only recently needed.
Dan.
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|