On Thu, Sep 27, 2018 at 04:32:37PM +0200, Fabiano Fidêncio wrote:
On Thu, 2018-09-27 at 16:13 +0200, Pavel Hrdina wrote:
This reverts commit 1602aa28f820ada66f707cef3e536e8572fbda1e.
There is no need to call virCgroupRemove() nor virCgroupFree() if virCgroupEnableMissingControllers() fails because it will not modify 'group' at all. The cleanup is done in virCgroupMakeGroup().
I wouldn't mention "The cleanup is done in virCGroupMakeGroup() because there's no cleanup needed from virCgroupEnableMissingControllers() as groups is only modified in case of success.
It's not a cleanup of 'group' variable but cleanup of the directories created on host.
I'd wait for John's ACK as well, but: Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
I can modify the commit message to make it more obvious. Pavel