2011/7/8 Eric Blake <eblake@redhat.com>:
On 07/07/2011 04:21 PM, Eric Blake wrote:
Oh, and our testsuite has a cosmetic bug. After applying your patch, I see this during 'make check':
TEST: xencapstest .......... 10 OK PASS: xencapstest SKIP: reconnect TEST: statstest 0 FAIL SKIP: statstest
Bonus points for fixing up that output to say SKIP instead of FAIL and to align it correctly (but that can be a separate patch).
As long as we're investigating formatting errors, this one is also annoying:
TEST: virsh-all ........................................ 40 ........................................ 80 ........................................ 120 ....................................... 159 OK PASS: virsh-all
We're obviously getting the logic wrong when there are 0 or when tests%40 == 39.
Here are two patches for this, plus one to use EXIT_AM_SKIP more. -- Matthias Bolte http://photron.blogspot.com