Re: [libvirt] [PATCH 6/9] qemu: always assume QEMU_CAPS_VFIO_PCI_BOOTINDEX

7 Sep 2018


      On Fri, 2018-09-07 at 16:08 +0200, Ján Tomko wrote:
...
Introduced by QEMU commit c29029d which was released in 1.5.0
s/released/included/
...
-                if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) {
-                    if (subsys->u.pci.backend ==
-                        VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
-                        if (!virQEMUCapsGet(qemuCaps,
-                                            QEMU_CAPS_VFIO_PCI_BOOTINDEX)) {
-                            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                                           _("booting from PCI devices assigned with VFIO "
-                                             "is not supported with this version of qemu"));
-                            return -1;
-                        }
-                    }
-                }
if (nesting) {
        if (nesting->type == NESTING_UNNECESSARY) {
            if (!nesting_is_desirable(NESTING_UNNECESSARY)) {
                goto ack;
            }
        }
    }

 ack:
    /* Reviewed-by: Andrea Bolognani <abologna@redhat.com> */

-- 
Andrea Bolognani / Red Hat / Virtualization