Re: [libvirt] [PATCH v2] qemu: Unlink managed state file when a domain is undefined
On 04/25/2011 03:41 AM, Osier Yang wrote:
The managed state file is not useful anymore after the domain is
undefined, and perhaps cause confusion. E.g. define & start a domain
which has same name but different UUID with previous undefined
domain later.
v1 - v2:
* Try to delete the managed state file before delete domain
config file, and goto fail if it failed to delete it.
---
src/qemu/qemu_driver.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
Ouch. virDomainUndefine doesn't have a flags argument. But this is
changing behavior in a user-visible manner (arguably for the better, but
any change is risky)
We have two options:
1. Proceed with the change: virDomainUndefine removes all associated
snapshot data; but this is a silent change in behavior
2. Add a new API: virDomainUndefineFlags; flag 0 leaves snapshot data
around (but warns), flag VIR_DOMAIN_UNDEFINE_ALL_ASSOCIATED_DATA (or
some better name) guarantees that snapshots are also removed
Being an API question, I think danpb might need to weigh in before we
make a change.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)