On Fri, Dec 12, 2008 at 10:46:27AM +0000, Daniel P. Berrange wrote:
On Fri, Dec 12, 2008 at 11:40:23AM +0100, Daniel Veillard wrote:
So applied and commited, thanks a lot, but I'm still puzzled, why did we end out of memory, I will look quickly
The 'out of memory' message is a red-herring - its a bogus error reporting path after the failure. Something that also needs fixing...
numa_node_to_cpus in the new version of libnuma seems to be a macro doing more checks than the older entry point, umlCapsInitNUMA() returns -1 and we assumed it was possible only if running out of memory. I guess reporting a normal error is better, note the patch will touch the strerror cleanup, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/