Re: [libvirt] [PATCH 4/8] qemu: command: Use more appropriate checking function for block devices

On 05/02/2016 10:32 AM, Peter Krempa wrote:

In qemuCheckDiskConfig would now use virDomainDiskSourceIsBlockType just as a glorified version of virStorageSourceIsBlockLocal that reports error messages. Replace it with the latter including the message for clarity. --- src/qemu/qemu_command.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)

Hmmm... I wonder if the previous commit should remove or at least reference the check in virDomainDiskSourceIsBlockType that neglected to consider the translation and actualtype... ACK for this - your call on whether to adjust the previous commit... John