On Mon, Oct 06, 2008 at 03:28:21PM +0200, Stefan de Konink wrote:
Stefan de Konink schreef:
Stefan de Konink schreef:
I'm try to migrate using libvirt:
virsh # migrate 0802367323_PIQ002 xen://xen002.local/ libvir: Xen Daemon error : POST operation failed: xend_post: error from xen daemon: (xend.err 'Missing parameter: node')
virsh -v 0.4.6
Xen 3.3
The xend/server/SrvDomain.py includes:
def do_migrate(self, _, req): fn = FormFn(self.xd.domain_migrate, [['dom', 'int'], ['destination', 'str'], ['live', 'int'], ['port', 'int'], ['node', 'int'], ['ssl', 'int']]) return fn(req.args, {'dom': self.dom.domid})
Since FormFn does a check on the required parameter,
4077 /* Make the call. */ 4078 ret = xend_op (domain->conn, domain->name, 4079 "op", "migrate", 4080 "destination", hostname, 4081 "live", live, 4082 "port", port, 4083 "resource", "0", /* required, xend ignores it */ "node", "-1", /* what does it do? */ "ssl", "0", 4084 NULL);
A diff is really nicer to avoid ambiguities !
Could probably fix it.
Well what happens if you make that change ? Is the migration successful ? If you can verify with the change ? Then it's worth checking further, for example that this doesn't break older versions of Xen, which should be the case, if i understand xend/Args.py correctly it will only use parameters requested in teh spec so extra args will be dropped.
But I don't know if the right approach is now to switch back to the development branch or, kindly request, a 0.4.6.1
We have no such patch in the devel branch that I can think of. And I don't see the relation to a new release with a different numbering scheme. Care to explain ? Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/