Re: [libvirt] [PATCH 06/23] Add missing 'goto error' in QEMU command line building
On Fri, Sep 14, 2012 at 09:50:26AM -0600, Eric Blake wrote:
On 09/14/2012 09:20 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> If reporting case of a binary not supporting KVM or kQEMU, libvirt
> forgot to jump to the error branch for cleanup
> ---
> src/qemu/qemu_command.c | 2 ++
> 1 file changed, 2 insertions(+)
My ACK from last time still stands.
In case it wasn't obvious, despite being seemingly trivial, this
change exposed a bug in this method, as well as in the test suite
that conspired together to hide themselves. Hence the 2 previous
new patches.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|