On Wed, May 18, 2016 at 19:08:01 -0400, John Ferlan wrote: [...]
1. Separate out the mock for virRandomBytes. I realize this is not the desired state, but figured to at least be prepared for what would be coming as a followup to:
http://www.redhat.com/archives/libvir-list/2016-May/msg00735.html
Looking at it back I think that patch is okay by itself. Adding the mock for virRandomBytes to deal with UUID generation is going to be worth a separate patch with separate justification to take care of different parts of the test suite.
OK - I can make it official; however, I was trying to figure out a way to be able to add a test to ensure that the "mocked" function was called from the tests... That whole environment is BFM (as I'm sure Michal can now attest).
Erm I think you misunderstood. I was referring to my patch that you've linked above. I wanted to point out that the patch as-is is fine for fixing the mocking in this case and that if we want to moc virRandomBytes to be used for UUID generation and such is stuff for a separate patch. Peter