Re: [libvirt] [PATCH]: Export the 'label' on block devices

Daniel P. Berrange wrote:

I don't understand why it has to be 1-billion ? For the enum support to work correctly, we need this to be contiguous, starting from zero, and and as the last element have

VIR_STORAGE_POOL_DISK_LAST

This perhaps suggests that DISK_UNKNOWN should be the first entry so that if you have a zero'd struct with a disk type, it'll get defaulted to UNKOWN

Yeah, after changing the DOS type to 1, I now realize that UNKNOWN should be the 0'th entry. I'll change that, change to the VIR_ENUM implementation as you suggest, fix up the fallout, and repost. Thanks, -- Chris Lalancette