Re: [Libvir] [PATCH] Don't throw away errors in virConnectOpen (at least not so often)
On Tue, May 01, 2007 at 03:04:32PM +0100, Richard W.M. Jones wrote:
Error messages, I like them. I don't like them to be thrown
away.
A nice feature of virterror is that it'll throw away errors under the
following conditions:
(1) You are in virConnectOpen, and
(2) You pass a non-NULL virConnectPtr to __virRaiseError.
libvirt has a lot of errors which meet those conditions - the attached
patch fixes the ones I could find.
It also fixes qemuOpenConnection so that it doesn't try to open a Unix
socket with random stack data.
It also adds error messages in some useful places where previously there
was an error, but no message.
In general that looks okay, but instead of passing NULL as the first
argument can't we do a selection in __virRaiseError instead based on the
type of error and just avoid virConnectOpen errors which are not related to
unavailability of the virtualization ?
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/