Re: [libvirt] [PATCH] Change return value of VIR_DRV_SUPPORTS_FEATURE to bool

>> diff --git a/src/driver.h b/src/driver.h >> index b770e5e..e797a75 100644 >> --- a/src/driver.h >> +++ b/src/driver.h >> @@ -52,12 +52,12 @@ typedef enum { >> * Note that you must check for errors. > > However, this comment is no longer applicable. So you'll need a v2 that > fixes the documentation, and make it explicit that the macro ignores > errors, as well as a cross-reference to the actual function for someone > that cares about errors. Ah, I haven't noticed that line... What about the following v2?

/* Internal feature-detection macro. Don't call drv->supports_feature - * directly, because it may be NULL, use this macro instead. + * directly if you don't have to, because it may be NULL, use this macro + * instead. * - * Note that you must check for errors. + * Note that this treats a possible error returned by drv->supports_feature + * the same as not supported. If you care about the error, call + * drv->supports_feature directly. *