On Tue, Jul 19, 2011 at 08:36:33AM -0600, Eric Blake wrote:
On 07/19/2011 07:22 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange@redhat.com>
Since the I/O callback registered against virNetSocket will hold a reference on the virNetClient, we can't rely on the virNetClientFree to be able to close the network connection. The last reference will only go away when the event callback fires (likely due to EOF from the server).
This is sub-optimal and can potentially cause a leak of the virNetClient object if the server were to not explicitly close the socket itself
* src/remote/remote_driver.c: Explicitly close the client object when disconnecting * src/rpc/virnetclient.c, src/rpc/virnetclient.h: Add a virNetClientClose method --- src/remote/remote_driver.c | 2 ++ src/rpc/virnetclient.c | 22 +++++++++++++++++++++- src/rpc/virnetclient.h | 1 + 3 files changed, 24 insertions(+), 1 deletions(-)
ACK.
Thanks, pushed these 4, plus the other migration error one I posted separately Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|