Re: [libvirt] [PATCHv2 11/11] qemu_driver: BaselineHypervisorCPU supports S390 using QEMU/QMP

Quoting David Hildenbrand (2018-07-18 02:26:24) I am runing tests on both S390 and X86 (hacked QEMU to enable baseline). I don't see a "false" property in the baseline response in any of the logs. I did try to slip a "zpci":false into the query-cpu-model-baseline but I still don't get a false in the response. Here is the request/response for reference. {"execute":"query-cpu-model-baseline", "arguments":{"modela":{"name":"z14"}, "modelb":{"name":"z13","props":{"msa5":true,"exrl":true,"zpci":false}}}, "id":"libvirt-2"} {"return": {"model": {"name": "z13-base","props": {"aen": true, "aefsi": true, "msa5": true, "msa4": true, "msa3": true, "msa2": true, "msa1": true, "sthyi": true, "edat": true, "ri": true, "edat2": true, "vx": true, "ipter": true, "esop": true, "cte": true, "sea_esop2": true, "te": true, "cmm": true}}}, "id": "libvirt-2"} Seems like were saying I should be filtering out or otherwise property excluding any false properties that are returned. Please correct if I have this wrong. I currently do filtering / exclusion on the result of expansion but seems like I should be doing filtering on baseline output too if we don't do the expansion just in case baseline would return a false property for some reason. Here is my understanding: 1) query-cpu-model-baseline will only return migratable properties. 2) query-cpu-model-expansion on S390 only returns migratable properties. In fact, here is what happens if you ask S390 for non-migratable features too: {"execute":"query-cpu-model-expansion", "arguments":{"type":"static","model":{"name":"host","props":{"migratable":false}}},"id":"libvirt-45"} Line [{"id": "libvirt-45", "error": {"class": "GenericError", "desc": "Property '.migratable' not found"}}] 3) There seem to be two usecases for expansion A/ Enumrate migratable properties in the baseline model B/ Enumerate both migratable and nonmigratable props in baseline model. B/ Doesn't work on S390 but A/ does. Here is what A/ looks like: {"execute":"query-cpu-model-baseline", "arguments":{"modela":{"name":"z13-base"},"modelb":{"name":"z13-base"}}, "id":"libvirt-4"} Line [{"return": {"model": {"name": "z13-base"}}, "id": "libvirt-4"}] *** {"execute":"query-cpu-model-expansion", "arguments":{"type":"full","model":{"name":"z13-base"}},"id":"libvirt-5"} Line [{"return": {"model": {"name": "z13-base", "props": {"pfmfi": false, "exrl": true, "stfle45": true, "cmma": false, "dateh2": true, "aen": false, "gen13ptff": true, "dateh": true, "cmmnt": false, "iacc2": true, "parseh": true, "csst": true, "idter": false, "idtes": true, "msa": true, "aefsi": false, "hpma2": false, "csst2": true, "csske": true, "mepoch": false, "msa8": false, "msa7": false, "msa6": false, "msa5": false, "msa4": false, "msa3": false, "msa2": false, "msa1": false, "sthyi": false, "stckf": true, "stfle": true, "edat": false, "etf3": true, "etf2": true, "hfpm": true, "ri": false, "edat2": false, "hfpue": true, "dfp": true, "mvcos": true, "sprogp": true, "sigpif": false, "ldisphp": true, "vx": false, "ipter": false, "emon": true, "cei": false, "cmpsceh": true, "ginste": true, "dfppc": true, "dfpzc": true, "dfphp": true, "stfle49": true, "mepochptff": false, "opc": false, "asnlxr": true, "gpereh": false, "minste2": false, "vxeh": false, "vxpd": false, "esop": false, "ectg": true, "ib": false, "siif": false, "tsi": false, "tpei": false, "esan3": true, "fpe": true, "ibs": false, "zarch": true, "stfle53": true, "sief2": false, "eimm": true, "iep": false, "irbm": false, "srs": true, "kss": false, "cte": false, "ais": false, "fpseh": true, "ltlbc": true, "ldisp": true, "bpb": false, "64bscao": false, "ctop": false, "gs": false, "sema": false, "etf3eh": true, "etf2eh": true, "eec": false, "ppa15": false, "zpci": false, "nonqks": true, "sea_esop2": false, "pfpo": true, "te": false, "cmm": false, "tods": true, "plo": true, "gsls": false, "skey": false}}}, "id": "libvirt-5"}] A problem here is if I set migratable_only (or migratable) to false then property "migratable":false is added to query-cpu-model-expansion. If X86 && model "name":"host" (limted of names) you get a successfull result. For all other archs and specific model names like (z13, IvyBridge) you get this: Line [{"id": "libvirt-45","error": {"class": "GenericError", "desc": "Property '.migratable' not found"}}] So unless something changes on the QEMU side you get nothing if you try to get query-cpu-model-expansion to enumerate non-migratable features outside the X86 + name: host type of usecases.