Re: [libvirt PATCH 037/351] meson: add readline build option
On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote:
On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote:
> Gross hack in our CI vs gross hack in spec file. I vote for CI to have
> the hack.
>
> In addition the macros are provided by meson and there are changes in
> the macro file, for example the latest macro file uses `meson compile`
> instead of `ninja build` which was introduced in 0.54.0 so we would have
> to have some older copy of the macros.
Not really, since the version of Meson that we use for building would
still be the one installed from PyPi, eg. 0.54.0 or newer. What about
the other way around? Would the old macros work fine with the newer
Meson?
An alternative idea, meson 0.54.0 depends on Python 3.8 ABI. Python 3.8 is
available on CentOS-8, so maybe we could try asking for a meson 0.54 build on
CentOS 8 as well.
CentOS 7 would be great too, but I'm willing to accept a compromise here that
we will only do an RPM build on the latest CentOS. I mean, compiling the code
on CentOS 7 is one thing, but building an RPM brings its own
issues/dependencies (a similar problem can be observed with libvirt-tck where
CentOS 7 simply turned out to be an unsuitable platform), from upstream POV we
mainly care about the latest releases of our dependencies for any *reasonable*
development anyway, so shifting the focus slightly to the latest CentOS in
terms of doing an RPM build doesn't seem like such an issue to me - all of
^this assuming we could get a newer meson build.
Erik